Skip to content

refactor(services/obs): migrate obs to reqsign-core v2#7169

Merged
Xuanwo merged 1 commit intomainfrom
migrate-obs-to-reqsign-core-v2
Feb 23, 2026
Merged

refactor(services/obs): migrate obs to reqsign-core v2#7169
Xuanwo merged 1 commit intomainfrom
migrate-obs-to-reqsign-core-v2

Conversation

@koushiro
Copy link
Member

@koushiro koushiro commented Jan 30, 2026

Which issue does this PR close?

Part of #6553

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

AI Usage Statement

Codex gpt-5.2 high

@koushiro koushiro requested a review from Xuanwo as a code owner January 30, 2026 12:00
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" labels Jan 30, 2026
if let Some(v) = self.config.secret_access_key {
cfg.secret_access_key = Some(v);
if let (Some(ak), Some(sk)) = (&self.config.access_key_id, &self.config.secret_access_key) {
let static_provider = StaticCredentialProvider::new(ak, sk);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, do we need to add security_token to ObsConfig?

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 23, 2026
@Xuanwo Xuanwo merged commit 4dabc46 into main Feb 23, 2026
1014 of 1017 checks passed
@Xuanwo Xuanwo deleted the migrate-obs-to-reqsign-core-v2 branch February 23, 2026 05:55
@dosubot
Copy link

dosubot bot commented Feb 23, 2026

Related Documentation

Checked 0 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants